[ 
https://issues.apache.org/jira/browse/TRAFODION-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753724#comment-15753724
 ] 

ASF GitHub Bot commented on TRAFODION-2211:
-------------------------------------------

Github user traflm commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/879#discussion_r92764647
  
    --- Diff: 
core/conn/trafci/src/main/java/org/trafodion/ci/ConsoleReader.java ---
    @@ -172,7 +176,8 @@ public String readLine() throws 
UnsupportedEncodingException, UserInterruption,
     
    --- End diff --
    
    This will remove Ctrl-C signal handler, did you test Ctrl-C in trafci? It 
should do a 'cancel query' if I remember it correctly. Anyway, you should make 
sure Ctrl-C has same behavior as before, should not be broken by this change. 
    I am not sure, need to check the trafci manual, but wondering if you have 
tested it or not? Since you comments out the signal handler.


> trafci should support up, down, left, right key in the keyboard
> ---------------------------------------------------------------
>
>                 Key: TRAFODION-2211
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2211
>             Project: Apache Trafodion
>          Issue Type: New Feature
>          Components: client-ci
>            Reporter: Joshua Liu
>            Assignee: mashengchen
>            Priority: Minor
>
> in trafci command interface,
> if we click the 'up' key, then we should have a previous statement
> and 'down' for the following
> then use left or right key to modify



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to