[ 
https://issues.apache.org/jira/browse/TRAFODION-2417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770531#comment-15770531
 ] 

ASF GitHub Bot commented on TRAFODION-2417:
-------------------------------------------

Github user amandamoran commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/888#discussion_r93659688
  
    --- Diff: install/installer/dcs_installer ---
    @@ -130,34 +130,12 @@ fi
     mkdir -p $DCS_INSTALL_PATH
     cd $DCS_INSTALL_PATH
     
    -if [[ "$ONE_TAR_INSTALL" == "Y" ]]; then
    -   DCS_DIR=$(ls $TRAF_HOME | grep dcs)
    -   DCS_DIR=$TRAF_HOME/$DCS_DIR
    -   echo "***INFO: DCS Install Directory: $DCS_DIR"
    -else
    -   # untar DCS build into install directory
    -   echo "***INFO: untarring build file $DCS_BUILD_FILE"
    -   tar -xzf $DCS_BUILD_FILE
    -
    -   # get the dcs install directory name which is imbedded in the tar file
    -   DCS_DIR=$(tar -tf $DCS_BUILD_FILE | grep --max-count=1 bin | sed -e 
"s@\(^.*\)/bin/@\1@")
    -
    -   DCS_DIR=$DCS_INSTALL_PATH/$DCS_DIR
    -fi
    -
    -# set env var in sqenvcom.sh for DCS install directory
    -grep --invert-match "DCS_INSTALL_DIR=" $TRAF_HOME/sqenvcom.sh > 
$TRAF_HOME/sqenvcom.temp
    -echo "export DCS_INSTALL_DIR=$DCS_DIR" >> $TRAF_HOME/sqenvcom.temp
    -mv $TRAF_HOME/sqenvcom.temp $TRAF_HOME/sqenvcom.sh
    +DCS_DIR=$(ls $TRAF_HOME | grep dcs)
    --- End diff --
    
    So happy to see $ONE_TAR_INSTALL being removed. +1


> Pre-work for ambari integration
> -------------------------------
>
>                 Key: TRAFODION-2417
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2417
>             Project: Apache Trafodion
>          Issue Type: Sub-task
>          Components: installer
>            Reporter: Steve Varnau
>
> Some install operations done in the command line installers (bash/python) can 
> be done as part of RPM install. Particularly, system limits config & sudo 
> config for trafodion user.  These are not dependent on cluster configuration.
> Secondly, the command-line installers modify the trafci script at install 
> time. This can be re-factored so that we just modify a config file rather 
> than modify the script itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to