[ 
https://issues.apache.org/jira/browse/TRAFODION-2414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770734#comment-15770734
 ] 

ASF GitHub Bot commented on TRAFODION-2414:
-------------------------------------------

Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/885#discussion_r93672871
  
    --- Diff: core/sqf/src/seatrans/tm/hbasetmlib2/javaobjectinterfacetm.cpp ---
    @@ -478,3 +514,23 @@ void 
JavaObjectInterfaceTM::appendExceptionMessages(JNIEnv *jenv, jthrowable a_e
         jenv->DeleteLocalRef(a_exception);
     }
     
    +short JavaObjectInterfaceTM::getExceptionErrorCode(JNIEnv *jenv, 
jthrowable a_exception)
    +{
    +  jshort errCode = JOI_OK;
    +  if(a_exception != NULL)
    +  {
    +    //Check to see if this exception has getErrorCode method.
    +    //Only custom subclasses have errorcode defined.
    --- End diff --
    
    Consider caching the methodId or it is an expensive way to get the error 
code. Is this method called only when error is present


> 8616 error to display transaction conflict details.  
> -----------------------------------------------------
>
>                 Key: TRAFODION-2414
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2414
>             Project: Apache Trafodion
>          Issue Type: Improvement
>          Components: dtm, sql-exe
>    Affects Versions: any
>            Reporter: Prashanth Vasudev
>            Assignee: Prashanth Vasudev
>             Fix For: 2.1-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to