[
https://issues.apache.org/jira/browse/TRAFODION-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15803851#comment-15803851
]
ASF GitHub Bot commented on TRAFODION-2430:
-------------------------------------------
Github user svarnau commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/906#discussion_r94908975
--- Diff: install/Makefile ---
@@ -17,28 +17,42 @@
RELEASE_VER ?= ${TRAFODION_VER}-incubating
RELEASE_TYPE ?= $(shell echo $(TRAFODION_VER_PROD)| sed -e 's/ /-/g')
INSTALLER_TARNAME = $(shell echo
${RELEASE_TYPE}_installer-${RELEASE_VER}.tar.gz |tr '[A-Z]' '[a-z]')
+PYINSTALLER_TARNAME = $(shell echo
${RELEASE_TYPE}_pyinstaller-${RELEASE_VER}.tar.gz |tr '[A-Z]' '[a-z]')
-all: pkg-installer
+all: pkg-installer
-pkg-installer: installer/LICENSE installer/NOTICE installer/DISCLAIMER
+pkg-installer: installer/LICENSE installer/NOTICE installer/DISCLAIMER \
+ python-installer/LICENSE python-installer/NOTICE
python-installer/DISCLAIMER
tar czf ${INSTALLER_TARNAME} installer --exclude=tools
+ tar czf ${PYINSTALLER_TARNAME} python-installer
mkdir -p ../distribution
--- End diff --
Rather than build two tarballs in one makefile target, I think it would be
cleaner to make another target, and have all target depend on both.
> python installer - need to modify Makefile for building a tar package
> ---------------------------------------------------------------------
>
> Key: TRAFODION-2430
> URL: https://issues.apache.org/jira/browse/TRAFODION-2430
> Project: Apache Trafodion
> Issue Type: Bug
> Components: installer
> Reporter: Eason Zhang
> Assignee: Eason Zhang
>
> need to modify Makefile for building a tar package
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
