[ 
https://issues.apache.org/jira/browse/TRAFODION-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815684#comment-15815684
 ] 

ASF GitHub Bot commented on TRAFODION-2431:
-------------------------------------------

Github user svarnau commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/908#discussion_r95421369
  
    --- Diff: .rat-excludes ---
    @@ -166,8 +166,14 @@ VariableLengthPKTest.java
     # asciidoc extention file -- MIT license
     google-analytics-postprocessor.rb
     
    -# installer JSON config files
    +# pyinstaller JSON config files
     mod_cfgs.json
     prompt.json
     script.json
     version.json
    +
    +# pyinstaller dependencies
    +prettytable.py
    +socks.py
    +iri2uri.py
    +__init__.py
    --- End diff --
    
    These files all have headers. RAT is only confused by two of them 
(prettytable & socks). So the others should NOT be listed in this file.
    
    Also, comment here should not just state what they are, but why they should 
be excluded from check -- they have BSD-3 license that RAT does not recognize.


> python installer - add python lib dependencies
> ----------------------------------------------
>
>                 Key: TRAFODION-2431
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2431
>             Project: Apache Trafodion
>          Issue Type: Bug
>          Components: installer
>            Reporter: Eason Zhang
>            Assignee: Eason Zhang
>
> Add python lib dependencies into installer directory, so user doesn't need to 
> download by themselves.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to