[ 
https://issues.apache.org/jira/browse/TRAFODION-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848604#comment-15848604
 ] 

ASF GitHub Bot commented on TRAFODION-2433:
-------------------------------------------

Github user prashanth-vasudev commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/909#discussion_r98937516
  
    --- Diff: core/sql/arkcmp/CompException.cpp ---
    @@ -113,11 +114,21 @@ FatalException::FatalException(const char *msg,
       else {
         msg_[0] = 0;
       }
    +  if(stackTrace) {
    +    strncpy(stackTrace_, stackTrace, sizeof(stackTrace_));
    +    stackTrace_[sizeof(stackTrace_)-1] = 0;
    --- End diff --
    
    Yes. stackTrace_ and msg_ are declared as stackTrace_[max len] and msg_[max 
len] in core/sql/arkcmp/CompException.h.  This is part of the diffs in this PR.


> Logging function call trace upon internal assert failures.
> ----------------------------------------------------------
>
>                 Key: TRAFODION-2433
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2433
>             Project: Apache Trafodion
>          Issue Type: Improvement
>          Components: sql-general
>            Reporter: Prashanth Vasudev
>            Assignee: Prashanth Vasudev
>
> Internal Asserts most of the time do not create core files nor return enough 
> information to debug the issue. 
> This is an attempt to capture the function call trace and log it as part of 
> assertion failure. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to