[
https://issues.apache.org/jira/browse/TRAFODION-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945715#comment-15945715
]
ASF GitHub Bot commented on TRAFODION-2449:
-------------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1028#discussion_r108502509
--- Diff: core/sqf/src/seatrans/tm/hbasetmlib2/hbasetm.cpp ---
@@ -1218,6 +1220,22 @@ char* HashMapArray::get(int tid)
return cp_val;
}
+char* HashMapArray::getRegionInfo(int64 tid)
+{
+ jstring js_val = (jstring)(_tlp_jenv->CallObjectMethod(javaObj_,
JavaMethods_[JM_GET_REGINFO].methodID, tid));
+ if (getExceptionDetails(NULL)) {
+ tm_log_write(DTM_TM_JNI_ERROR, SQ_LOG_ERR, (char
*)"HashMapArray::getRegionInfo()", (char *)_tlp_error_msg->c_str(), -1LL);
+ return NULL;
+ }
+ if(js_val == NULL){
+ return NULL;
+ }
+
+ const jbyte* jb_val = (jbyte*)_tlp_jenv->GetStringUTFChars(js_val,
NULL);
--- End diff --
Do we need to worry about memory leaks from C++ references to Java
variables? I don't see any code in this module that does worry about this, but
the executor code (see for example
$TRAF_HOME/../sql/executor/HBaseClient_JNI.cpp) is very careful to push and pop
frames to avoid memory leaks. Perhaps the TM is handling this issue in a
different way?
> dtmci - Enhance to include HBase-related info for status
> ---------------------------------------------------------
>
> Key: TRAFODION-2449
> URL: https://issues.apache.org/jira/browse/TRAFODION-2449
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: dtm
> Affects Versions: 2.2-incubating
> Reporter: Oliver Bucaojit
> Priority: Minor
> Attachments: status_regions.png, TRAFODION-2449.v1.patch,
> TRAFODION-2449.v2.patch
>
>
> Request for enhancement
> dtmci 'status trans' does not show information regarding table name,
> regionserver, or region. It would be beneficial for troubleshooting and
> understanding the path taken by a transaction to include HBase related
> information.
> Initial idea would be to add a 'detailed' option to specifying the trans id.
> DTMCI > status trans <transid>, detailed
> Looking at the code, this work would require adding JNI calls from the tm
> process to the HBaseTxClient class to gather this information.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
