[ 
https://issues.apache.org/jira/browse/TRAFODION-2554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950211#comment-15950211
 ] 

ASF GitHub Bot commented on TRAFODION-2554:
-------------------------------------------

Github user arvind-narain commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1036#discussion_r109077021
  
    --- Diff: core/conn/jdbc_type2/Makefile ---
    @@ -57,7 +57,15 @@ T2_OBJS  = $(OUTDIR)/CommonDiags.o \
            $(OUTDIR)/ResStatisticsStatement.o \
            $(OUTDIR)/Vproc.o \
            $(OUTDIR)/type2version.o
    -
    +CSES := org.trafodion.jdbc.t2.JdbcDebug \
    +           org.trafodion.jdbc.t2.DataWrapper \
    +           org.trafodion.jdbc.t2.SQLMXCallableStatement \
    +           org.trafodion.jdbc.t2.SQLMXConnection \
    +           org.trafodion.jdbc.t2.SQLMXDatabaseMetaData \
    +           org.trafodion.jdbc.t2.T2Driver \
    +           org.trafodion.jdbc.t2.SQLMXPreparedStatement \
    +           org.trafodion.jdbc.t2.SQLMXResultSet \
    +           org.trafodion.jdbc.t2.SQLMXStatement
    --- End diff --
    
    Would this change be needed if we touch the package name in T2 source to 
include apache ? Should we change the package name (org.apache.trafodion...) in 
the source and the file layout  to make it consistent ?


> JDBC T2 build changes needed  for Trafodion release 
> ----------------------------------------------------
>
>                 Key: TRAFODION-2554
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2554
>             Project: Apache Trafodion
>          Issue Type: Task
>          Components: client-jdbc-t2
>    Affects Versions: 2.2-incubating
>            Reporter: Sandhya Sundaresan
>            Assignee: Alex Peng
>
> Need to convert T2 project to use Maven.
> Change POM.xml to be consistent with other POM files in Trafodion so we can 
> publish the T2  jar file. 
> The group id needs to change to org.apache.trafodion.
> The NOTICE and LICENSE files need to be part of the JAR's META INF directory. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to