[
https://issues.apache.org/jira/browse/TRAFODION-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987002#comment-15987002
]
ASF GitHub Bot commented on TRAFODION-2294:
-------------------------------------------
GitHub user DaveBirdsall opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1074
[TRAFODION-2294] Fix permissions hole in Explain
This set of changes does the following:
1. Changes EXPLAIN so that it does not cache the query plan of whatever
query it is explaining. This closes a permissions hole that otherwise allows
one to execute the query afterward without privilege checking.
2. Extract the SqlParser_Flags_Enum from parser/SqlParserGlobalsCmn.h into
a new file parser/SqlParserGlobalsEnum.h, to make it easier to use these
literals in executor code. I changed a few hard-coded constants to their
associated literals in executor/ExExeUtilExplain.cpp as well.
3. Update privs1/TEST120 regression test to include a test of the hole
fixed by item 1 above.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion2294
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1074.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1074
----
commit 9e37f06dcf033b6d95309ff4c401fa73abaf3314
Author: Dave Birdsall <[email protected]>
Date: 2017-04-27T16:43:05Z
[TRAFODION-2294] Fix permissions hole in Explain
----
> need add privilege checking for explain statement
> -------------------------------------------------
>
> Key: TRAFODION-2294
> URL: https://issues.apache.org/jira/browse/TRAFODION-2294
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-security
> Environment: CDH5.4.8
> Centos6.7
> Reporter: Gao, Rui-Xian
> Assignee: David Wayne Birdsall
>
> we don't have privilege checking for 'explain' statements.If a user doesn't
> have privilege to execute a statement, then after explain, the user will be
> able to execute the statement.
> Testuser1:
> SQL>create schema testsch1;
>
> --- SQL operation complete.
>
> SQL>set schema testsch1;
>
> --- SQL operation complete.
>
> SQL>create table tab1(a int, b int);
>
> --- SQL operation complete.
>
> SQL>insert into tab1 values(1,1);
>
> --- 1 row(s) inserted.
>
> SQL>select * from tab1;
>
> A B
> ----------- -----------
> 1 1
>
> --- 1 row(s) selected.
>
> Tesuser2:
> SQL>set schema testsch1;
>
> --- SQL operation complete.
>
> SQL>get tables;
>
> Tables in Schema TRAFODION.TESTSCH1
> ===================================
>
> SB_HISTOGRAMS
> SB_HISTOGRAM_INTERVALS
> SB_PERSISTENT_SAMPLES
> TAB1
>
> --- SQL operation complete.
>
> SQL>select * from tab1;
>
> *** ERROR[4481] The user does not have SELECT privilege on table or view
> TRAFODION.TESTSCH1.TAB1. [2016-10-18 09:07:32]
>
> SQL>explain options 'f' select * from tab1;
>
>
> LC RC OP OPERATOR OPT DESCRIPTION CARD
> ---- ---- ---- -------------------- -------- -------------------- ---------
>
> 1 . 2 root 1.00E+002
> . . 1 trafodion_scan TAB1 1.00E+002
>
> --- SQL operation complete.
>
> SQL>select * from tab1;
>
> A B
> ----------- -----------
> 1 1
>
> --- 1 row(s) selected.
>
> SQL>insert into tab1 values(20,20);
>
> *** ERROR[4481] The user does not have INSERT privilege on table or view
> TRAFODION.TESTSCH1.TAB1. [2016-10-18 09:11:03]
>
> SQL>explain options 'f' insert into tab1 values(20,20);
>
>
> LC RC OP OPERATOR OPT DESCRIPTION CARD
> ---- ---- ---- -------------------- -------- -------------------- ---------
>
> 1 . 2 root o 1.00E+000
> . . 1 trafodion_insert TAB1 1.00E+000
>
> --- SQL operation complete.
>
> SQL>insert into tab1 values(20,20);
>
> --- 1 row(s) inserted.
>
> SQL>select * from tab1;
>
> A B
> ----------- -----------
> 20 20
> 1 1
>
> --- 2 row(s) selected.
>
> SQL>showddl tab1;
>
>
> CREATE TABLE TRAFODION.TESTSCH1.TAB1
> (
> A INT DEFAULT NULL SERIALIZED
> , B INT DEFAULT NULL SERIALIZED
> )
> ;
>
> -- GRANT SELECT, INSERT, DELETE, UPDATE, REFERENCES ON
> TRAFODION.TESTSCH1.TAB1 TO TESTUSER1 WITH GRANT OPTION;
>
> --- SQL operation complete.
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
