[
https://issues.apache.org/jira/browse/TRAFODION-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003547#comment-16003547
]
ASF GitHub Bot commented on TRAFODION-2420:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1087#discussion_r115595056
--- Diff: core/sql/executor/ex_hash_grby.cpp ---
@@ -452,6 +463,8 @@ short ex_hash_grby_tcb::work() {
hasFreeTupp_ = TRUE;
};
};
+ if (bmoStats_)
+ bmoStats_->setBmoPhase(PHASE_END-HGB_READ_PHASE);
--- End diff --
This is executed for every row. Would it be cheaper to do this in the two
places where we set state_ to HASH_GRBY_READ_CHILD?
Another question not about correctness but more related to personal taste:
Why not simply assign values 1, 2, 3 etc. in the enum instead of subtracting
two enums here? Feel free to ignore if you like this solution better.
> RMS enhancements
> ----------------
>
> Key: TRAFODION-2420
> URL: https://issues.apache.org/jira/browse/TRAFODION-2420
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: sql-general
> Affects Versions: 2.1-incubating
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
>
> Improve RMS to provide the following features/capabilities:
> 1. Currently RMS can list queries that consumed cpu time between two time
> points. However, the calls to storage engine like hbase, hdfs etc are
> blocking and these blocked APIs will not allow the Trafodion SQL engine
> scheduler to detect the cpu time spent during the time the call was blocked.
> Introduce a feature called SE offender (storage engine offender) to list the
> queries that are blocked in storage engine more than a certain duration.
> 2. Remove counters that are no longer updated or needed
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
