[ 
https://issues.apache.org/jira/browse/TRAFODION-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064114#comment-16064114
 ] 

ASF GitHub Bot commented on TRAFODION-2668:
-------------------------------------------

Github user kevinxu021 commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1144#discussion_r124161107
  
    --- Diff: dcs/src/main/java/org/trafodion/dcs/server/ServerManager.java ---
    @@ -400,7 +415,9 @@ public Boolean call() throws Exception {
                 // /bin/dcs-daemon script
                 // which DOES NOT set childServers count.
                 for (int childInstance = 1; childInstance <= childServers; 
childInstance++) {
    -                serverHandlers[childInstance-1] = new 
ServerHandler(childInstance);
    +                ServerHandler serverHandler = new 
ServerHandler(childInstance);
    +                serverHandler.setRestartAttempts(this.restartAttempts);
    --- End diff --
    
    suggest to add a new constructor new ServerHandler(this.conf, 
childInstance), then if you add more KVs in the future, the only changes may 
from ServerHandler


> one mxosrvr can't startup, dcsServer down
> -----------------------------------------
>
>                 Key: TRAFODION-2668
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2668
>             Project: Apache Trafodion
>          Issue Type: Bug
>            Reporter: mashengchen
>            Assignee: mashengchen
>
> if one of the mxosrvr have any error, while dscserver is starting, dcsserver 
> will down



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to