[ 
https://issues.apache.org/jira/browse/TRAFODION-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078248#comment-16078248
 ] 

ASF GitHub Bot commented on TRAFODION-2308:
-------------------------------------------

Github user xwq commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1167#discussion_r126176560
  
    --- Diff: core/sql/optimizer/BindItemExpr.cpp ---
    @@ -6105,12 +6105,21 @@ ItemExpr *Assign::bindNode(BindWA *bindWA)
                   ItemExpr *newChild;
                   const NAType &desiredType = child(0)->getValueId().getType();
                   SQLBlob &lobType = (SQLBlob&)desiredType;
    -
    -              NAType * newType = new 
SQLBlob((CmpCommon::getDefaultNumeric(LOB_MAX_SIZE)*1024*1024), 
    +              short fs_datatype = 
child(0)->castToItemExpr()->getValueId().getType().getFSDatatype();
    +
    +              NAType * newType = NULL;
    +              if (fs_datatype == REC_CLOB) {
    +                  newType = new 
SQLClob((CmpCommon::getDefaultNumeric(LOB_MAX_SIZE) * 1024 * 1024),
    +                         lobType.getLobStorage(),
    +                         TRUE, FALSE, TRUE,
    +                         CmpCommon::getDefaultNumeric(LOB_BATCH_SIZE));
    +              }
    +              else {
    +              newType = new 
SQLBlob((CmpCommon::getDefaultNumeric(LOB_MAX_SIZE)*1024*1024),
                                                  lobType.getLobStorage(), 
                                                  TRUE, FALSE, TRUE, 
    -                                             
CmpCommon::getDefaultNumeric(LOB_MAX_CHUNK_MEM_SIZE)*1024*1024); 
    -              //              vid1.coerceType(desiredType, NA_LOB_TYPE); 
    +                                             
CmpCommon::getDefaultNumeric(LOB_BATCH_SIZE));
    +              }
    --- End diff --
    
    I think it's better to compare the CQD and this 'param'. If the param is 
larger, I will use CQD, else use the param.  I will change it.


> JDBC T4 support read LOB
> ------------------------
>
>                 Key: TRAFODION-2308
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2308
>             Project: Apache Trafodion
>          Issue Type: Sub-task
>          Components: client-jdbc-t4, connectivity-mxosrvr
>            Reporter: Weiqing Xu
>            Assignee: Weiqing Xu
>
> JDBC T4 need implement some API to support CLOB and BLOB.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to