[
https://issues.apache.org/jira/browse/TRAFODION-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090468#comment-16090468
]
ASF GitHub Bot commented on TRAFODION-2628:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1170#discussion_r127812127
--- Diff: core/sql/optimizer/NAClusterInfo.cpp ---
@@ -350,14 +244,8 @@ NAClusterInfo::NAClusterInfo(CollHeap * heap)
if ((nodeInfo[i].type & MS_Mon_ZoneType_Aggregation) != 0 ||
--- End diff --
Yes, I would say we should look at the node type. Here is what I found in
file core/sqf/export/include/seabed/ms.h:
MS_Mon_ZoneType_Undefined = 0x0000, // No zone type defined
MS_Mon_ZoneType_Edge = 0x0001, // Zone of service only nodes
MS_Mon_ZoneType_Aggregation = 0x0002, // Zone of compute only nodes
MS_Mon_ZoneType_Storage = 0x0004, // Zone of storage only nodes
MS_Mon_ZoneType_Excluded = 0x0010, // Excluded cores
Maybe we should only look at nodes of type "MS_Mon_ZoneType_Aggregation",
just like NAClusterInfo does it? If you agree I can make that change.
> SQL engine work for Elasticity [TRAFODION-2001]
> -----------------------------------------------
>
> Key: TRAFODION-2628
> URL: https://issues.apache.org/jira/browse/TRAFODION-2628
> Project: Apache Trafodion
> Issue Type: Sub-task
> Components: sql-cmp
> Affects Versions: 2.2-incubating
> Reporter: Hans Zeller
> Assignee: Hans Zeller
> Fix For: 2.2-incubating
>
>
> See discussion in TRAFODION-2001. We need to accommodate node ids in a
> cluster that contain "holes".
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
