[
https://issues.apache.org/jira/browse/TRAFODION-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269100#comment-16269100
]
ASF GitHub Bot commented on TRAFODION-2821:
-------------------------------------------
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1314#discussion_r153565344
--- Diff: core/sql/executor/OrcFileReader.cpp ---
@@ -122,24 +150,28 @@ OFR_RetCode OrcFileReader::init()
OFR_RetCode OrcFileReader::open(const char* path)
{
QRLogger::log(CAT_SQL_HDFS_ORC_FILE_READER, LL_DEBUG,
"OrcFileReader::open(%s) called.", path);
+
+ if (initJNIEnv() != JOI_OK)
+ return OFR_ERROR_OPEN_PARAM;
jstring js_path = jenv_->NewStringUTF(path);
if (js_path == NULL)
+ {
+ jenv_->PopLocalFrame(NULL);
--- End diff --
I'm a little confused about the rules for when a call to PopLocalFrame is
needed. Is it needed whenever we have previously done a call into any jenv_
method? (in this case NewStringUTF).
> Trafodion core code base needs to be thread safe
> -------------------------------------------------
>
> Key: TRAFODION-2821
> URL: https://issues.apache.org/jira/browse/TRAFODION-2821
> Project: Apache Trafodion
> Issue Type: Improvement
> Components: sql-general
> Affects Versions: any
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
> Fix For: 2.3-incubating
>
>
> This is the covering trafodion jira to make trafodion core code base to be
> thread safe. It is needed to ensure that type T2 JDBC driver hosted on
> platform can be enabled to support multi-threaded JDBC applications.
> [TRAFODION-2783] is one such case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
