[
https://issues.apache.org/jira/browse/TRAFODION-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291688#comment-16291688
]
ASF GitHub Bot commented on TRAFODION-2844:
-------------------------------------------
Github user hegdean commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1344#discussion_r157074271
--- Diff: dcs/src/main/java/org/trafodion/dcs/server/ServerManager.java ---
@@ -255,33 +259,17 @@ private void cleanupZk() {
CountDownLatch startSignal = new CountDownLatch(1);
RetryCounter retryCounter;
- public void reset() {
- startSignal.countDown();
- startSignal = new CountDownLatch(1);
- boolean isRunning = this.serverMonitor.monitor();
- String nid = this.serverMonitor.nid;
- String pid = this.serverMonitor.pid;
-
- if (isRunning) {
- LOG.info("mxosrvr " + nid + "," + pid + " still running");
- this.retryCounter.resetAttemptTimes();
- } else {
- LOG.info("mxosrvr " + nid + "," + pid + " exited,
restarting, restart attempt time : "
- + this.retryCounter.getAttemptTimes());
- }
- }
-
public ServerHandler(Configuration conf ,int childInstance) {
int maxRestartAttempts =
conf.getInt(Constants.DCS_SERVER_USER_PROGRAM_RESTART_HANDLER_ATTEMPTS,
Constants.DEFAULT_DCS_SERVER_USER_PROGRAM_RESTART_HANDLER_ATTEMPTS);
- int retryIntervalMillis = conf.getInt(
-
Constants.DCS_SERVER_USER_PROGRAM_RESTART_HANDLER_RETRY_INTERVAL_MILLIS,
-
Constants.DEFAULT_DCS_SERVER_USER_PROGRAM_RESTART_HANDLER_RETRY_INTERVAL_MILLIS);
+ int retryIntervalMinutes = conf.getInt(
--- End diff --
Why did we change from millis to minutes. Millis is more granular and you
can achieve mins from millis
> dcsserver restart mxosrvr should have a time range
> --------------------------------------------------
>
> Key: TRAFODION-2844
> URL: https://issues.apache.org/jira/browse/TRAFODION-2844
> Project: Apache Trafodion
> Issue Type: Bug
> Components: dcs
> Reporter: mashengchen
> Assignee: mashengchen
>
> when mxosrvr down ,dcsserver will restart it , and if mxosrvr down a lot of
> times in a period of time , there should reject the restart. if time between
> 6 times age(default setting) and this time are a very long time, dcsserver
> should allow the restart
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
