wForget commented on PR #36: URL: https://github.com/apache/incubator-uniffle/pull/36#issuecomment-1176134269
@jerqi Thank you for your reply > Shuffle server already have provide a metric http api. The metric app_num_with_node will tell you how many apps there are on the node. We recommend that we use this metric to judge whether to be able to stop the server. When we want to redeploy the shuffle server, we need to mark the server to be offline first, and then stop it when there is no application handle in the shuffle server. I want to implement an rest api in the shuffle server that first marks the server as offline, then starts a check thread that checks if the number of applications being processed by the shuffle server is empty, and then stops it. > If you want to add rest api to stop server, is it possible to imitate the CommonMetricsServlet to create another Servlet? Using HttpServlet should work, but the implemented code looks complicated. Is this feature reasonable? If reasonable I would use HttpServlet to implement it. > If we want to add some Servlets to control shuffle server's behavior, do we need some more detailed discussions? Yes, looks like more details need to be discussed, I will open an issue to follow up it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
