frankliee commented on PR #13:
URL: https://github.com/apache/incubator-uniffle/pull/13#issuecomment-1176962586

   > > I know this is not easy because getting MR stack is difficult in local.
   > 
   > What I mean "not easy“ is to build a cross-version **Spark IT** that 
covers all gRPC APIs used by RSS.
   > 
   > > The reproduction is complicated ... 3) switch to the master branch and 
recompile ...
   > 
   > It's clear to me when you said "See MRIntegrationTestBase `File file = new 
File(parentPath, "client-mr/target/shaded");`". But for step 3, it's better to 
switch back to `ec00ad9`, which is the commit I cut the branch out, the master 
has gone ahead.
   > 
   > > but it is better to notify the client/server should be the same version 
in the document.
   > 
   > I would prefer to dig out the root cause before documenting the 
conclusion. My first round of cross-version testing failed but the following 
rounds were successful. And the first-round failure is because I put the new MR 
client jar to a temp folder, if there are some temp files deleted by other 
processes during testing, the test will fail w/
   > 
   > ```
   > java.io.IOException: /home/chengpan/.docker/run/docker-cli-api.sock: No 
such file or directory
   >         at 
org.apache.uniffle.test.WordCountTest.wordCountTest(WordCountTest.java:66)
   > ```
   > 
   > And if I put the client-mr jar build w/ new gRPC version to an immutable 
folder, then IT passed.
   > 
   > I finally found and checked the MR tasks log, and do not see any related 
stacks.
   
   The compatibility is ok. I am sorry, and I found the wrong jar is copied...  
 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to