jerqi commented on code in PR #49:
URL: https://github.com/apache/incubator-uniffle/pull/49#discussion_r918152723
##########
common/src/main/java/org/apache/uniffle/common/util/ThreadUtils.java:
##########
@@ -0,0 +1,15 @@
+package org.apache.uniffle.common.util;
Review Comment:
Could you add license header? Because our project need to follow Apache 2.0
license.
##########
common/src/main/java/org/apache/uniffle/common/util/ThreadUtils.java:
##########
@@ -0,0 +1,15 @@
+package org.apache.uniffle.common.util;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+
+import java.util.concurrent.ThreadFactory;
+
+/**
+ * Provide a general method to create a thread factory to make the code more
standardized
+ */
+public class ThreadUtils {
+
+ public static ThreadFactory getThreadFactory(String factoryName) {
+ return new
ThreadFactoryBuilder().setDaemon(true).setNameFormat(factoryName).build();
+ }
+}
Review Comment:
Could you add new line? Otherwise, there will be a format warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
