frankliee commented on code in PR #55:
URL: https://github.com/apache/incubator-uniffle/pull/55#discussion_r921886503
##########
client-mr/src/main/java/org/apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java:
##########
@@ -201,21 +201,22 @@ public Thread newThread(Runnable r) {
extraConf.set(RssMRConfig.RSS_REMOTE_STORAGE_CONF,
remoteStorage.getConfString());
// When containers have disk with very limited space, reduce is allowed
to spill data to hdfs
- if (extraConf.getBoolean(RssMRConfig.RSS_REDUCE_REMOTE_SPILL_ENABLED,
+ if (conf.getBoolean(RssMRConfig.RSS_REDUCE_REMOTE_SPILL_ENABLED,
RssMRConfig.RSS_REDUCE_REMOTE_SPILL_ENABLED_DEFAULT)) {
- if (storageType != StorageType.MEMORY_LOCALFILE_HDFS.name()) {
+ if (storageType != StorageType.MEMORY_LOCALFILE_HDFS.name()
+ || remoteStorage.isEmpty()) {
Review Comment:
I think storageType check is also required to avoid illegal status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
