jerqi commented on code in PR #59:
URL: https://github.com/apache/incubator-uniffle/pull/59#discussion_r922680037
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -88,11 +88,12 @@ public class ShuffleWriteClientImpl implements
ShuffleWriteClient {
private int replicaRead;
private boolean replicaSkipEnabled;
private int dataTranferPoolSize;
+ private int commitSenderPoolSize = -1;
private final ForkJoinPool dataTransferPool;
public ShuffleWriteClientImpl(String clientType, int retryMax, long
retryIntervalMax, int heartBeatThreadNum,
int replica, int replicaWrite, int
replicaRead, boolean replicaSkipEnabled,
- int dataTranferPoolSize) {
+ int dataTranferPoolSize, int
commitSenderPoolSize) {
Review Comment:
We prefer the code style as below
```
public ShuffleWriteClientImpl(
String clientType,
int retryMax,
long retryIntervalMax,
int heartBeatThreadNum,
int replica,
int replicaWrite,
int replicaRead,
boolean replicaSkipEnabled,
int dataTranferPoolSize,
int commitSenderPoolSize) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
