duanmeng commented on code in PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#discussion_r922947393
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorGrpcService.java:
##########
@@ -206,7 +207,10 @@ public void accessCluster(AccessClusterRequest request,
StreamObserver<AccessClu
AccessClusterResponse response;
AccessManager accessManager = coordinatorServer.getAccessManager();
- AccessInfo accessInfo = new AccessInfo(request.getAccessId(),
Sets.newHashSet(request.getTagsList()));
+ Map<String, String> extraProperties = request.getExtraPropertiesMap();
+ AccessInfo accessInfo =
+ new AccessInfo(request.getAccessId(),
Sets.newHashSet(request.getTagsList()),
+ extraProperties == null ? Collections.emptyMap() :
extraProperties);
Review Comment:
It'd be better to let the `AccessInfo` handle the case where the parameter
`extraProperties` is null in its constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
