jerqi commented on code in PR #53:
URL: https://github.com/apache/incubator-uniffle/pull/53#discussion_r936173653
##########
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java:
##########
@@ -157,6 +156,32 @@ public class RssBaseConf extends RssConf {
.defaultValue(true)
.withDescription("The switch for jvm metrics verbose");
+ public static final ConfigOption<Boolean> RSS_ACCESS_HADOOP_KERBEROS_ENABLE
= ConfigOptions
+ .key("rss.access.hadoop.kerberos.enable")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Whether enable visiting secured hadoop cluster.");
+
+ public static final ConfigOption<String>
RSS_ACCESS_HADOOP_KERBEROS_KEYTAB_FILE = ConfigOptions
+ .key("rss.access.hadoop.kerberos.keytab.file")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("The kerberos keytab file path. And only when "
+ + RSS_ACCESS_HADOOP_KERBEROS_ENABLE.key() + " enabled, the option
will be valid.");
+
+ public static final ConfigOption<String>
RSS_ACCESS_HADOOP_KERBEROS_PRINCIPAL = ConfigOptions
+ .key("rss.access.hadoop.kerberos.principal")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("The kerberos keytab principal. And only when "
+ + RSS_ACCESS_HADOOP_KERBEROS_ENABLE.key() + " enabled, the option
will be valid.");
+
+ public static final ConfigOption<Long>
RSS_ACCESS_HADOOP_KERBEROS_RELOGIN_INTERVAL = ConfigOptions
Review Comment:
RSS_ACCESS_HADOOP_KERBEROS_RELOGIN_INTERVAL ->
RSS_ACCESS_HADOOP_KERBEROS_RELOGIN_INTERVAL_SEC
Could we add unit to its name to help people understand the code easily?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
