zuston commented on code in PR #53:
URL: https://github.com/apache/incubator-uniffle/pull/53#discussion_r938420061
##########
server/src/main/java/org/apache/uniffle/server/storage/LocalStorageManager.java:
##########
@@ -170,6 +170,11 @@ public Checker getStorageChecker() {
return checker;
}
+ @Override
+ public String getStorageUser(String appId) {
+ return null;
Review Comment:
The user only will be used in kerberos HDFS. And when in kerberos HDFS and
user is null or empty, it will directly check and throw exception while
flushing shuffle data.
So i think we need not to consider the NPE. Or return the empty of string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
