izchen opened a new pull request, #141:
URL: https://github.com/apache/incubator-uniffle/pull/141

   ### What changes were proposed in this pull request?
   
   Do not use `InetAddress.getLocalHost().getHostAddress()`  in test because it 
is indeterminate. The return value may be different on a multi-NIC machine or 
on different system.
   
   ### Why are the changes needed?
   
   In addition to 127.0.0.1, the loopback address 127.0.1.1 can also be 
returned, which happens on Debian.This will make UT fail.
   
   ```
   org.opentest4j.AssertionFailedError: 
   Expected :127.0.1.1
   Actual   :10.0.191.230
   
   at 
org.apache.uniffle.common.util.RssUtilsTest.testGetHostIp(RssUtilsTest.java:64)
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   UT.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to