summaryzb commented on PR #67: URL: https://github.com/apache/incubator-uniffle/pull/67#issuecomment-1208073769
> @summaryzb can you describe more detail about how to save memory for buffer management? And I prefer to split this PR into 2 PRs for 'Bug fix' and 'Improvement' previously, we add `WrappedBuffer` to `buffers` in `WriterBuffer` class, but the byte[] in `WrappedBuffer` is not fully used. for example, the length of every record is 2k, every time we add a record, we create a buffer with 3k length by default and wrap the previous buffer as `WrappedBuffer` which resulting in wasting 1k memory in every `WrappedBuffer`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
