jerqi commented on code in PR #156:
URL: https://github.com/apache/incubator-uniffle/pull/156#discussion_r944217709
##########
coordinator/src/test/java/org/apache/uniffle/coordinator/ApplicationManagerTest.java:
##########
@@ -98,6 +98,24 @@ public void refreshTest() {
assertFalse(applicationManager.hasErrorInStatusCheck());
}
+ @Test
+ public void pickRemoteStorageTest() {
+ String remoteStoragePath = remotePath1 + Constants.COMMA_SPLIT_CHAR +
remotePath2;
Review Comment:
> Yes, at present, I have no way to understand the meaning of handling null
in the original sorting. So for the sake of insurance, I added filtering
conditions.
So this pr should be an improvement, not a bugfix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
