smallzhongfeng commented on code in PR #158:
URL: https://github.com/apache/incubator-uniffle/pull/158#discussion_r946566121
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -161,10 +156,9 @@ public StatusCode commitShuffle(String appId, int
shuffleId) throws Exception {
refreshAppId(appId);
Roaring64NavigableMap cachedBlockIds = getCachedBlockIds(appId, shuffleId);
Roaring64NavigableMap cloneBlockIds;
- commitLocks.putIfAbsent(appId, Maps.newConcurrentMap());
- Map<Integer, Object> shuffleLevelLocks = commitLocks.get(appId);
- shuffleLevelLocks.putIfAbsent(shuffleId, new Object());
- Object lock = shuffleLevelLocks.get(shuffleId);
+ shuffleTaskInfo.computeIfAbsent(appId, x -> new ShuffleTaskInfo())
Review Comment:
Good suggestion. Updated, the same below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
