zuston commented on code in PR #254: URL: https://github.com/apache/incubator-uniffle/pull/254#discussion_r990718592
########## client-spark/common/src/main/java/org/apache/spark/shuffle/reader/RssShuffleDataIterator.java: ########## @@ -38,8 +38,12 @@ import org.apache.uniffle.client.api.ShuffleReadClient; import org.apache.uniffle.client.response.CompressedShuffleBlock; -import org.apache.uniffle.common.RssShuffleUtils; -import org.apache.uniffle.common.exception.RssException; +import org.apache.uniffle.client.util.RssClientConfig; +import org.apache.uniffle.common.compression.CompressionFactory; +import org.apache.uniffle.common.compression.Decompressor; +import org.apache.uniffle.common.config.RssConf; + +import static org.apache.spark.shuffle.RssSparkConfig.RSS_WRITER_BUFFER_SIZE; Review Comment: Yes. We'd better to avoid this. And in later refactor, all client side's config should be involved in shareable `RssClientConf` class. This problem will not occur, which is mentioned in #200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
