smallzhongfeng commented on PR #265: URL: https://github.com/apache/incubator-uniffle/pull/265#issuecomment-1279947802
Because this static class is currently in `LowestIOSampleCostSelectStorageStrategy`, but `AppBalanceSelectStorageStrategy` will also use it, and other selection strategy may use it later, it will be common to set it as a normal class. In addition, sorting is required when selecting the optimal storage path. Sorting depends on this object. If other storage needs to rely on this `RankValue`, and more comparative attributes need to be added, it will be clearer to define these attributes in a separate class. WDYT ? @jerqi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
