fpkgithub commented on code in PR #266:
URL: https://github.com/apache/incubator-uniffle/pull/266#discussion_r997828783
##########
client-mr/src/main/java/org/apache/hadoop/mapred/SortWriteBufferManager.java:
##########
@@ -312,7 +312,7 @@ ShuffleBlockInfo createShuffleBlock(SortWriteBuffer wb) {
final byte[] compressed = RssShuffleUtils.compressData(data);
final long crc32 = ChecksumUtils.getCrc32(compressed);
compressTime += System.currentTimeMillis() - start;
- final long blockId = RssMRUtils.getBlockId(partitionId, taskAttemptId,
getNextSeqNo(partitionId));
+ final long blockId = RssMRUtils.getBlockId(Long.valueOf(partitionId),
taskAttemptId, getNextSeqNo(partitionId));
Review Comment:
ok , change to implicit type casting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
