leixm commented on code in PR #275:
URL: https://github.com/apache/incubator-uniffle/pull/275#discussion_r1001794946
##########
common/src/main/java/org/apache/uniffle/common/util/RssUtils.java:
##########
@@ -218,6 +220,13 @@ private static List<ShuffleDataSegment>
transIndexDataToSegments(byte[] indexDat
bufferSegments.add(new BufferSegment(blockId, bufferOffset, length,
uncompressLength, crc, taskAttemptId));
bufferOffset += length;
+ totalLength += length;
+
+ // If ShuffleServer is flushing the file at this time, the length in
the index file record may be greater
Review Comment:
It seems unreasonable to do a flush every time a block is written, so that
the buffer of the hdfs client will not work, and it will make performance
regession.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
