duanmeng commented on code in PR #276:
URL: https://github.com/apache/incubator-uniffle/pull/276#discussion_r1012792038
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/DataSkippableReadHandler.java:
##########
@@ -59,8 +60,17 @@ public DataSkippableReadHandler(
public ShuffleDataResult readShuffleData() {
if (shuffleDataSegments.isEmpty()) {
- ShuffleIndexResult shuffleIndexResult = readShuffleIndex();
+ ShuffleIndexResult shuffleIndexResult;
+ try {
+ shuffleIndexResult = readShuffleIndex();
+ } catch (Exception e) {
+ if (++failTimes > maxHanderFailTimes) {
+ isFinished = true;
+ }
+ throw e;
Review Comment:
>Yes, but what's the problem and what's the impact？I don't understand.
Not a problem, we do not need to record the retries in the low-level handlers
>Upper layer means ShuffleClient? I think we must retry in ShuffleClient
Yes, agree. Check consistency and call the reshuffleData in `ShuffleClient`,
and do the actual handlers retries (low-level handler loops) in the
`clientReadHandler`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
