jerqi commented on code in PR #293:
URL: https://github.com/apache/incubator-uniffle/pull/293#discussion_r1013656207
##########
storage/src/main/java/org/apache/uniffle/storage/factory/ShuffleHandlerFactory.java:
##########
@@ -136,7 +138,11 @@ private ClientReadHandler
getHdfsClientReadHandler(CreateShuffleReadHandlerReque
request.getExpectBlockIds(),
request.getProcessBlockIds(),
request.getStorageBasePath(),
- request.getHadoopConf());
+ request.getHadoopConf(),
+ request.getDistributionType(),
+ request.getStartMapIndex(),
Review Comment:
Do ClientReadHandler need startMapIndex and EndMapIndex?
I think it's a Spark AQE concept, I prefer not exposing them?
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
