jerqi commented on code in PR #307:
URL: https://github.com/apache/incubator-uniffle/pull/307#discussion_r1019787970
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorUtils.java:
##########
@@ -53,6 +54,59 @@ public static int nextIdx(int idx, int size) {
return idx;
}
+ /**
+ * Assign multiple adjacent partitionRanges to several servers
+ * Suppose totalPartitionNum=52, partitionNumPerRange=2, serverNum=5,
estimateTaskConcurrency=20
Review Comment:
`partitionNumPerRange` should be 1. We will remove range partition in the
future.. We can use this to simplify the logic. Current implement is ok for me,
too.
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorGrpcService.java:
##########
@@ -110,6 +110,7 @@ public void getShuffleAssignments(
final int replica = request.getDataReplica();
final Set<String> requiredTags =
Sets.newHashSet(request.getRequireTagsList());
final int requiredShuffleServerNumber =
request.getAssignmentShuffleServerNumber();
+ final int estimateTaskConcurrency = request.getEstimateTaskConcurrency();
Review Comment:
What will the value be if the old client request the server?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
