zuston commented on code in PR #310:
URL: https://github.com/apache/incubator-uniffle/pull/310#discussion_r1020707324
##########
server/src/main/java/org/apache/uniffle/server/RegisterHeartBeat.java:
##########
@@ -58,7 +58,7 @@ public RegisterHeartBeat(ShuffleServer shuffleServer) {
this.heartBeatTimeout =
conf.getLong(ShuffleServerConf.SERVER_HEARTBEAT_TIMEOUT);
this.coordinatorQuorum =
conf.getString(ShuffleServerConf.RSS_COORDINATOR_QUORUM);
CoordinatorClientFactory factory =
- new
CoordinatorClientFactory(conf.getString(ShuffleServerConf.RSS_CLIENT_TYPE));
+ new
CoordinatorClientFactory(conf.get(ShuffleServerConf.RSS_CLIENT_TYPE).name());
Review Comment:
We could make all client type change from `string` to `enum` in anywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
