jerqi commented on PR #319: URL: https://github.com/apache/incubator-uniffle/pull/319#issuecomment-1312961591
> > > Emm... Actually `AQESkewedJoinWithLocalOrderTest ` could be cover the bug of `expectedTaskIds `. However because the distribution type of LOCAL_ORDER is invalid with the incorrect initialization of shuffleReadClientImpl, it fall back to the NORMAL segment splitter, which cause the `AQESkewedJoinWithLocalOrderTest` run successfully. > > > it's a coincidence > > > > > > OK. It don't influence our performance test result, do it? > > Emm... All bugs are caused by #137 subsequent refactors of changing the [startMapId, endMapid) to taskIds bitmap. > > The performance results are based on the initial commit. So the result is OK. OK. LGTM, thanks @zuston -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
