zuston commented on code in PR #354:
URL: https://github.com/apache/incubator-uniffle/pull/354#discussion_r1030299415
##########
common/src/main/java/org/apache/uniffle/common/segment/LocalOrderSegmentSplitter.java:
##########
@@ -128,23 +129,13 @@ public List<ShuffleDataSegment> split(ShuffleIndexResult
shuffleIndexResult) {
}
if (expectTaskIds.contains(taskAttemptId)) {
- if (bufferOffset != 0 && index - lastExpectedBlockIndex > 1) {
Review Comment:
This checking logic is to check the discontinuous blocks in a ordered
sequence. So this will throw exception when encountering the discontinuous task
map ids
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
