jerqi commented on code in PR #276:
URL: https://github.com/apache/incubator-uniffle/pull/276#discussion_r1030332793
##########
storage/src/main/java/org/apache/uniffle/storage/factory/ShuffleHandlerFactory.java:
##########
@@ -54,79 +53,84 @@ public static synchronized ShuffleHandlerFactory
getInstance() {
}
public ClientReadHandler
createShuffleReadHandler(CreateShuffleReadHandlerRequest request) {
+ return createShuffleReadHandler(request, null);
+ }
+
+ public ClientReadHandler
createShuffleReadHandler(CreateShuffleReadHandlerRequest request,
+ ShuffleServerInfo
serverInfo) {
+ if (serverInfo == null && request.getShuffleServerInfoList().size() > 1) {
Review Comment:
The logic is a little tricky. Maybe they can extract the common logic to a
depend method. We can split this method to two methods. It's weird that we
judge serverInfo whether is empty and decide which handler to create.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
