jerqi commented on code in PR #357:
URL: https://github.com/apache/incubator-uniffle/pull/357#discussion_r1031470203
##########
storage/src/main/java/org/apache/uniffle/storage/handler/api/ShuffleDeleteHandler.java:
##########
@@ -25,4 +25,11 @@ public interface ShuffleDeleteHandler {
* @param appId ApplicationId for delete
*/
void delete(String[] storageBasePaths, String appId, String user);
+
+ /**
+ * Delete shuffle data with appId
+ *
+ * @param appId ApplicationId for delete
+ */
+ void delete(String[] storageBasePaths, String appId);
Review Comment:
Why do we need this interface? Could we reuse `delete(String[]
storageBasePaths, String appId, String user)`?
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -308,6 +308,12 @@ public class ShuffleServerConf extends RssBaseConf {
.defaultValue(60 * 1000L)
.withDescription("The timeout of the cache which record the mapping
information");
+ public static final ConfigOption<Long>
SERVER_LEAK_SHUFFLE_DATA_CHECK_INTERVAL = ConfigOptions
Review Comment:
Could you add this config option in our document
https://github.com/apache/incubator-uniffle/blob/master/docs/server_guide.md ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
