jerqi commented on code in PR #358:
URL: https://github.com/apache/incubator-uniffle/pull/358#discussion_r1032859657


##########
proto/src/main/proto/Rss.proto:
##########
@@ -92,6 +92,7 @@ message GetMemoryShuffleDataRequest {
   int64 lastBlockId = 4;
   int32 readBufferSize = 5;
   int64 timestamp = 6;
+  optional bytes serializedTaskIdsBitmap = 7;

Review Comment:
   > I wonder why we need excludeTaskIdsBitmap?
   
   For multi replicas, it may be better if we have excludeTaskIdsBitmap. This 
name is not good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to