jerqi commented on code in PR #361:
URL: https://github.com/apache/incubator-uniffle/pull/361#discussion_r1032886976
##########
client/src/main/java/org/apache/uniffle/client/factory/ShuffleClientFactory.java:
##########
@@ -49,6 +49,11 @@ public ShuffleWriteClient createShuffleWriteClient(
String clientType, int retryMax, long retryIntervalMax, int
heartBeatThreadNum,
int replica, int replicaWrite, int replicaRead, boolean
replicaSkipEnabled, int dataTransferPoolSize,
int dataCommitPoolSize, int unregisterThreadPoolSize, int
unregisterRequestTimeoutSec) {
+ // If replica > replicaWrite, blocks maybe will be sended for 2 rounds.
+ // We need retry less times in this case for let the first round fail fast.
+ if (replica > replicaWrite) {
Review Comment:
Should we use `replicaSkipEnabled`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
