zuston commented on code in PR #383:
URL: https://github.com/apache/incubator-uniffle/pull/383#discussion_r1038101787
##########
server/src/main/java/org/apache/uniffle/server/ShuffleDataFlushEvent.java:
##########
@@ -105,6 +109,22 @@ public void increaseRetryTimes() {
retryTimes.incrementAndGet();
}
+ public boolean isPended() {
+ return isPended;
+ }
+
+ public void markPended() {
+ isPended = true;
+ }
+
+ public Storage getUnderStorage() {
+ return underStorage;
Review Comment:
For the getting concrete storage when updating metrics. In original logic,
the storage will be gotten by invoking selectStorage method. This is
unreasonable.
We should guarantee that StorageManager#selectStorage only could be invoked
before writing. After written, the storage has been bound to event, we
shouldn’t invoke selectStorage again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
