jerqi commented on PR #308:
URL:
https://github.com/apache/incubator-uniffle/pull/308#issuecomment-1336153996
There are several questions to solve?
1. If we use Netty, the feature may not take effect.
So I think we should we could support this feature when we use GRPC. If
we have Netty, Netty won't support this feature first. You can accomplish this
feature based on Netty version.
2. If we use multi replicas, it may cause some errors.
If we retry a recovery replica too many times. I think this feature can't
work with multi relicas.
3. Recovery is a complicated operation. It's hard to review every condition,
error will occur sometimes. If blockBitMap is persist, do you need crc? How to
check whether we lose some state?
4. Let me think twice. Is the best to way to retry our request in the
handler?
5. Will retryhandler break the mechinsm of fast fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
