jerqi commented on code in PR #294:
URL: https://github.com/apache/incubator-uniffle/pull/294#discussion_r1039667344
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/reader/RssShuffleReader.java:
##########
@@ -210,7 +218,8 @@ public Configuration getHadoopConf() {
CreateShuffleReadClientRequest request = new
CreateShuffleReadClientRequest(
appId, shuffleId, partition, storageType, basePath,
indexReadLimit, readBufferSize,
1, partitionNum, partitionToExpectBlocks.get(partition),
taskIdBitmap, shuffleServerInfoList,
- hadoopConf, dataDistributionType,
expectedTaskIdsBitmapFilterEnable);
+ hadoopConf, dataDistributionType,
expectedTaskIdsBitmapFilterEnable,
Review Comment:
What's situation that we use `expectedTaskIdsBitmapFilterEnable`? If we
don't use aqe and multi replicas, the taskbitmap will occupy several KB memory.
But we could filter less data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
