advancedxy commented on code in PR #393:
URL: https://github.com/apache/incubator-uniffle/pull/393#discussion_r1042939677


##########
server/src/main/java/org/apache/uniffle/server/LocalStorageChecker.java:
##########
@@ -164,7 +164,8 @@ boolean checkStorageReadAndWrite() {
       if (storage.isCorrupted()) {
         return false;
       }
-      File checkDir = new File(storageDir, "check");
+      // Use the hidden file to avoid being cleanup
+      File checkDir = new File(storageDir, ".check");

Review Comment:
   Nit, make `.check` a final static variable, and we can reference this name 
in test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to