jerqi commented on code in PR #394:
URL: https://github.com/apache/incubator-uniffle/pull/394#discussion_r1043451631
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleReadClientImpl.java:
##########
@@ -183,8 +183,7 @@ public CompressedShuffleBlock readShuffleBlockData() {
long actualCrc = -1;
try {
long start = System.currentTimeMillis();
- copyTime.addAndGet(System.currentTimeMillis() - start);
- start = System.currentTimeMillis();
+ // copyTime seems make no sense?
Review Comment:
Yes, we don't copy data now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
