xianjingfeng commented on code in PR #294:
URL: https://github.com/apache/incubator-uniffle/pull/294#discussion_r1045162120
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/MemoryClientReadHandler.java:
##########
@@ -66,18 +76,32 @@ public MemoryClientReadHandler(
int readBufferSize,
ShuffleServerClient shuffleServerClient,
Roaring64NavigableMap expectTaskIds,
- boolean expectedTaskIdsBitmapFilterEnable) {
+ Roaring64NavigableMap expectBlockIds,
+ Roaring64NavigableMap processBlockIds,
+ BlockSkipStrategy blockSkipStrategy,
+ int maxBlockIdRangeSegments) {
this.appId = appId;
this.shuffleId = shuffleId;
this.partitionId = partitionId;
this.readBufferSize = readBufferSize;
this.shuffleServerClient = shuffleServerClient;
this.expectTaskIds = expectTaskIds;
- this.expectedTaskIdsBitmapFilterEnable = expectedTaskIdsBitmapFilterEnable;
+ this.expectBlockIds = expectBlockIds;
+ this.processBlockIds = processBlockIds;
+ this.blockSkipStrategy = blockSkipStrategy;
+ this.maxBlockIdRangeSegments = maxBlockIdRangeSegments;
}
@Override
public ShuffleDataResult readShuffleData() {
+ if (BlockSkipStrategy.BLOCKID_RANGE.equals(blockSkipStrategy) &&
lastBlockId == Constants.INVALID_BLOCK_ID) {
Review Comment:
We only need to build the blockId range at the first time the handler read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
