zuston commented on code in PR #396:
URL: https://github.com/apache/incubator-uniffle/pull/396#discussion_r1046609494
##########
integration-test/common/src/test/java/org/apache/uniffle/test/ShuffleServerWithHdfsTest.java:
##########
@@ -51,10 +51,10 @@
public class ShuffleServerWithHdfsTest extends ShuffleReadWriteBase {
- private ShuffleServerGrpcClient shuffleServerClient;
+ protected ShuffleServerGrpcClient shuffleServerClient;
@BeforeAll
- public static void setupServers() throws Exception {
+ private static void setupServers() throws Exception {
Review Comment:
Yes. Override and hidden are all OK. Lets make identifier public
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
