kaijchen commented on PR #421: URL: https://github.com/apache/incubator-uniffle/pull/421#issuecomment-1351542283
Thanks @xianjingfeng for the work. A few suggestion here: 1. You can use Awaitility for the wait, see https://github.com/apache/incubator-uniffle/search?q=awaitility 2. Please prove this change actually fixes the flaky test. For example (see below), you can change this test to a ParameterizedTest locally and repeat it many times. ```java static IntStream range() { return IntStream.range(0, 100); } @ParameterizedTest @MethodSource("range") public void testDetectUserResource(int dummy) throws Exception { ``` The test result (before the change): NOTE: Seems there are some issues in iteration 58, maybe we should add a `@Timeout`. <img width="example result" alt="image" src="https://user-images.githubusercontent.com/5821159/207625193-f106c725-b2eb-4be7-93af-4188abc975b7.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/5821159/207625193-f106c725-b2eb-4be7-93af-4188abc975b7.png"](https://user-images.githubusercontent.com/5821159/207625193-f106c725-b2eb-4be7-93af-4188abc975b7.png"){kind=link}