advancedxy commented on code in PR #445:
URL: https://github.com/apache/incubator-uniffle/pull/445#discussion_r1056143145
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -431,20 +436,28 @@ private Map<String, Set<Integer>> pickFlushedShuffle() {
long expectedFlushSize = highWaterMark - lowWaterMark;
long pickedFlushSize = 0L;
int printIndex = 0;
+ int printIgnoreIndex = 0;
int printMax = 10;
for (Map.Entry<String, AtomicLong> entry : sizeList) {
long size = entry.getValue().get();
- pickedFlushSize += size;
String appIdShuffleIdKey = entry.getKey();
- addPickedShuffle(appIdShuffleIdKey, pickedShuffle);
- // print detail picked info
- if (printIndex < printMax) {
- LOG.info("Pick application_shuffleId[{}] with {} bytes",
appIdShuffleIdKey, size);
- printIndex++;
- }
- if (pickedFlushSize > expectedFlushSize) {
- LOG.info("Finish flush pick with {} bytes", pickedFlushSize);
- break;
+ if (size > this.shuffleFlushThreshold) {
Review Comment:
Also, It could be a bit more adaptive to select shuffleIds to flush... such
as if it doesn't free any memory, then just ignore the threshold and re-select
the shuffle ids... But I think it's a bit of overkill/over engineering in this
stage to introduce such flexibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
